Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 101 should mention bug tracker and buildbots #1405

Open
vstinner opened this issue May 19, 2020 · 10 comments
Open

PEP 101 should mention bug tracker and buildbots #1405

vstinner opened this issue May 19, 2020 · 10 comments
Assignees

Comments

@vstinner
Copy link
Member

When master became Python 3.10 and 3.9 branch was created, we had to:

@vstinner
Copy link
Member Author

cc @pablogsal @zware @ambv

@vstinner
Copy link
Member Author

Oh, it also seems like when a new branch (like 3.9) is created, we don't get all pre-commit CIs by default: see python/core-workflow#369

@AA-Turner
Copy link
Member

Assigning Barry and Guido as PEP 101 authors.
A

@gvanrossum
Copy link
Member

I don’t know enough about this topic to care anymore. :-)

Maybe this PEP needs a new owner?

@AA-Turner
Copy link
Member

I'll admit my assigning people was half a prompt to update this issue / see if it should be closed! I've removed you now.

Perhaps the release managers should be owners? @ambv @pablogsal @ned-deily (sorry if I missed anyone!)

A

@JelleZijlstra
Copy link
Member

I think someone just needs to send a PR and then we should get maybe get signoff from one of the recent release managers (Pablo, Łukasz, or Ned).

@warsaw
Copy link
Member

warsaw commented Jan 23, 2022

Yes, please consult a release manager for one of the active versions of Python 😄 . In fact, I wouldn't mind if one or all of the above take over as Authors of PEP 101.

@pablogsal
Copy link
Member

I can take ownership of the PEP for the time being :)

@ambv do you want to join the party?

@ambv
Copy link
Contributor

ambv commented Jan 24, 2022

Yes, please :-)

@CAM-Gerlach
Copy link
Member

As far as I can tell, the original two points @vstinner listed above are as of now at least mentioned in the PEP, as sub-bullets under the final list item, the "you will need to ensure various pieces of the development infrastructure are updated for the new branch" one:

  • If this is a new branch release, you will need to ensure various pieces of the development infrastructure are updated for the new branch. These include:
    * Update the issue tracker for the new branch.
    * Add the new version to the versions list (contact the tracker admins?).
    * Add a regressions keyword for the release
  • Ensure buildbots are defined for the new branch (contact zware).

Is there anything specific that should be added to them?

Adding the additional pre-commit CIs may be implied by

  • Verify that CI is working for new PRs for the main and new release branches and that the release branch is properly protected (no direct pushes, etc).

but not directly stated, so it would seem that might be worth adding.

Whoever makes the PR on this can add you two to the CODEOWNERS and remove Barry and Guido.

Do either of you want to submit that? What about @vstinner ? If you have something specific you want to add/change, one of us can try to take care of it for you and submit the PR for your review, since I'm sure you're busy people.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants