Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Jam Extension Facelift #61

Open
D0rs4n opened this issue Sep 12, 2022 · 0 comments
Open

Code Jam Extension Facelift #61

D0rs4n opened this issue Sep 12, 2022 · 0 comments
Labels
Area: Code Jam Needs Discussion Proposed feature, but it needs additional discussion to confirm implementation details/approach

Comments

@D0rs4n
Copy link
Member

D0rs4n commented Sep 12, 2022

Before the Code Jam some features (the majority of them) weren't implemented in an optimal manner, hence a facelift PR is required.
A few notes from previous PRs:

  • There is a common pattern in Sir Robin where we get a team, handle possible API errors, and the proceed with the data gathered from the API. This procedure should be moved to a helper function.
    • Return the data as dataclasses (/pydantic models), so that we don't have to slice dicts everywhere.
  • Set the Textbox's type to be TextArea when adding notes.
  • Utilize jam_categories upon cj create

If anyone has suggestions, please mention below this issue.

@D0rs4n D0rs4n added Needs Discussion Proposed feature, but it needs additional discussion to confirm implementation details/approach Area: Code Jam labels Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Code Jam Needs Discussion Proposed feature, but it needs additional discussion to confirm implementation details/approach
Projects
None yet
Development

No branches or pull requests

1 participant