Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raising an exception in a callback to pytest.Config.add_cleanup doesn't allow subsequent cleanups to run. #12981

Open
graingert opened this issue Nov 20, 2024 · 1 comment · May be fixed by #12982
Open

raising an exception in a callback to pytest.Config.add_cleanup doesn't allow subsequent cleanups to run. #12981

graingert opened this issue Nov 20, 2024 · 1 comment · May be fixed by #12982

Comments

@graingert
Copy link
Member 

          I just noticed that raising an exception in a callback to Config.add_cleanup doesn't allow subsequent cleanups to run. I'll fix this in another pr

Originally posted by @graingert in #12958 (comment)
@graingert
Copy link
Member Author

Probably this should be an ExitStack

@graingert graingert linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent Config.add_cleanup callbacks preventing other cleanups running pytest-dev/pytest
1 participant
@graingert