-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy docstrings to wrapped pdb methods #12947
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adamchainz!
e5679c5
to
c27a64f
Compare
Hmm the tests are failing, can you take a look @adamchainz ? |
do_c = do_cont = do_continue | ||
|
||
def do_quit(self, arg): | ||
"""Raise Exit outcome when quit command is used in pdb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep this as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to copy the original docstring from do_quit
, which is the purpose of the PR... turning into a comment makes sure we do not lose that information.
@@ -0,0 +1 @@ | |||
Fixed missing help for :mod:`pdb` commands wrapped by pytest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(optional)
Fixed missing help for :mod:`pdb` commands wrapped by pytest. | |
Fixed missing help for :mod:`pdb` commands wrapped by pytest -- by :user:`adamchainz`. |
Closes #12946.