Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom PropagationLabelsPrefix #1124

Open
prein opened this issue Mar 28, 2024 · 2 comments
Open

Custom PropagationLabelsPrefix #1124

prein opened this issue Mar 28, 2024 · 2 comments

Comments

@prein
Copy link

prein commented Mar 28, 2024

Any chance PropagationLabelsPrefix can be configurable? We are using / in some of our labels. Prefixing with pyrra.dev/ makes Kubernetes barf. Labels are allowed to contain only one slash.

@metalmatze
Copy link
Member

Can you give some more concrete examples? That'd be helpful.
I don't think anything speaks against making it more configurable other than a bit more complexity in the code.

@prein
Copy link
Author

prein commented Apr 2, 2024

Thanks for reply. Re: example. In my organization we use labels prefixed with company name, such as companyname/owner or companyname/component. Prefixing them with another slash containing prefix gives errors like the following when attempting to create the SLO resource

pyrra.dev/companyname/owner": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. '[example.com/MyName](http://example.com/MyName)'),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants