Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we support brms' centering transform? #13

Open
null-a opened this issue Sep 30, 2019 · 3 comments
Open

Should we support brms' centering transform? #13

null-a opened this issue Sep 30, 2019 · 3 comments
Labels
discussion Requires broader discussion

Comments

@null-a
Copy link
Collaborator

null-a commented Sep 30, 2019

See the center arg. of brmsformula.

@eb8680
Copy link
Member

eb8680 commented Oct 14, 2019

@neerajprad Is this something we could support upstream with more generic transformations in Pyro, as in e.g. this paper?

@neerajprad
Copy link
Member

While we don't automatically reparametrize a model, a user can easily do so in NumPyro (not Pyro though) using TransformedDistributions. See this example on Neal's funnel. i.e. instead of using dist.Normal(mu, sigma) they can use dist.TransformedDistribution(dist.Normal(0., 1.), AffineTransform(mu, sigma)).

I think that should be sufficient for brmp since all the latents are being generated by us.

@null-a
Copy link
Collaborator Author

null-a commented Oct 28, 2019

I think we're talking about two different things here. The thing I had in mind (which I called "brms' centering transform") is a transform of the data (mean centering) which is enabled by default. I'm not sure whether this is important, but if we don't have it we might simply want to note it as a difference between the two systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Requires broader discussion
Projects
None yet
Development

No branches or pull requests

3 participants