Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links to corresponding resources into the email notification when receiving access to packages #6688

Open
webknjaz opened this issue Sep 22, 2019 · 7 comments · May be fixed by #16975
Open

Add links to corresponding resources into the email notification when receiving access to packages #6688

webknjaz opened this issue Sep 22, 2019 · 7 comments · May be fixed by #16975
Labels
email Related to emails good first issue This issue is ideal for first-time contributors! UX/UI design, user experience, user interface

Comments

@webknjaz
Copy link
Member

What's the problem this feature will solve?

I received this email recently:

You have been added as {{role}} to the PyPI project {{project_name}} by {{other_user}}.

—
You are receiving this because you have been added by {{other_user}} to a project on PyPI.

But there's not a single link in it. So if I were to open a role explanation on the help page, the project page or the user page, I'd have to type/search/copy things, which is not a good UX.

Describe the solution you'd like

I just want to have clickable things in that email.

Additional context

Corresponding templates:
@nlhkabu nlhkabu added the UX/UI design, user experience, user interface label Sep 23, 2019
@miketheman miketheman added the email Related to emails label Feb 6, 2024
@miketheman miketheman added the good first issue This issue is ideal for first-time contributors! label May 16, 2024
@miketheman
Copy link
Member

cc @aram-cinnamon we chatted about this - let me know if you need more pointers!

@CoderLogy
Copy link

CoderLogy commented Sep 3, 2024 •
edited
Loading

i can do it using ahref like this just assign me for this one
You have been added as <a href="https://pypi.org/help/#{{role}}">{{role}}</a> to the PyPI project <a href="https://pypi.org/project/{{project_name}}/">{{project_name}}</a> by <a href="https://pypi.org/user/{{other_user}}/">{{other_user}}</a>

@miketheman
Copy link
Member

@CoderLogy We do not assign issues to folks outside the organization, but if you'd like to put up a PR to resolve, please do so!
Read the contributing details in https://warehouse.pypa.io/development/index.html
and specifically the notes about Emails: https://warehouse.pypa.io/development/email.html
and Translations: https://warehouse.pypa.io/development/submitting-patches.html#translations

@CoderLogy
Copy link

@CoderLogy We do not assign issues to folks outside the organization, but if you'd like to put up a PR to resolve, please do so!

Read the contributing details in https://warehouse.pypa.io/development/index.html

and specifically the notes about Emails: https://warehouse.pypa.io/development/email.html

and Translations: https://warehouse.pypa.io/development/submitting-patches.html#translations

How can I join this organization.

@webknjaz
Copy link
Member Author

webknjaz commented Sep 4, 2024

@CoderLogy you don't have to. You can go ahead and open a PR right away if you're interested in working on this.

@CoderLogy
Copy link

Ok Thnks for letting me know, on my way to pr

@VineetHBhat
Copy link

Since the last activity on this issue was on September 4 and the isssue is still open, I am trying to work on this to create a PR. (DISCLAIMER: I am new to open source contributions)

@VineetHBhat VineetHBhat linked a pull request Oct 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
email Related to emails good first issue This issue is ideal for first-time contributors! UX/UI design, user experience, user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 6688: Added project, role and initiator user URLs to email VineetHBhat/warehouse
5 participants
@miketheman @webknjaz @nlhkabu @VineetHBhat @CoderLogy