Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure #1710

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jjakob
Copy link

@jjakob jjakob commented Jul 13, 2024

No description provided.

Copy link

@frogamic frogamic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came here to raise the same PR since pyocd is a dependency of a package I maintain in NixOS and this broken test is causing issues as we migrate to python 3.12.

test/unit/test_autoflush.py Outdated Show resolved Hide resolved
test/unit/test_autoflush.py Outdated Show resolved Hide resolved
@jjakob jjakob force-pushed the fix_test_autoflush_failure branch from 9b937c1 to fd200f2 Compare July 16, 2024 02:35
@jjakob
Copy link
Author

jjakob commented Jul 16, 2024

I'm not sure how this test is supposed to work but at least after @frogamic suggestions it's now syntactically correct, and it passes, so I'll leave it up to pyOCD developers to see if it actually does what they want it to do.

@jjakob jjakob force-pushed the fix_test_autoflush_failure branch from fd200f2 to 9c48236 Compare July 16, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants