Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: remove capstone #1670

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsiverskog
Copy link
Contributor

the implementation already supports that capstone may not be installed. capstone is somewhat slow to install on some platforms (e.g. raspberry pi), and not always needed.

the implementation already supports that capstone may not be
installed. capstone is somewhat slow to install on some platforms
(e.g. raspberry pi), and not always needed.
@jsiverskog jsiverskog force-pushed the make_capstone_an_optional_dep branch from f09da41 to 9844089 Compare February 9, 2024 08:23
Copy link
Member

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, Thank you for the contribution.

As I understand this, this is a matter of weighing the benefit for people using this step command and relying on it printing the asm versus people installing pyocd from pip on "slow" systems.

I don't personally have an opinion on that matter and don't feel legitimate to make the call on this.

@carlosperate
Copy link
Contributor

carlosperate commented Jul 12, 2024

Not indicating if this should be removed or kept in install_requires, but just to add a small comment that:
if it is going to be removed from install_requires it might be better if it goes into a different extras_require.
Maybe a new one, like pemicro? and maybe at that point it'd be good as well to add a third called all to include all options.
On top of that it would also be good to update all the documentation indicating how to install the different dependencies.

Of course, it's understandable not wanting to do the extra work without first knowing if a PR is going to be accepted, I just wanted to point this out to have it in consideration as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants