-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run CI on python=3.13
#9681
base: main
Are you sure you want to change the base?
run CI on python=3.13
#9681
Conversation
reason: `dask-expr` depends on `pyarrow`, which doesn't support python 3.13 yet
reason: depends on `webob`, which makes use of `cgi`, a stdlib that got removed in python 3.13
Interestingly it's |
Is there a reason we are installing conda? For the output of |
we use |
@@ -47,7 +47,7 @@ jobs: | |||
matrix: | |||
os: ["ubuntu-latest", "macos-latest", "windows-latest"] | |||
# Bookend python versions | |||
python-version: ["3.10", "3.12"] | |||
python-version: ["3.10", "3.12", "3.13"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we just stick to all-but-dask
given what we've had to comment out? If we're going to change this line, it'd be nice to drop 3.12 which we can't at the moment...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah dask/dask#11456 was just merged so this is coming...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm in the progress of checking whether that's still necessary. If yes, then sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, looks like this will still fail, but not for long. I don't think we can go with all-but-dask
, though, since that's still trying to install numba
/ sparse
/ numbagg
. Until that supports python=3.13
we'll have to live with 3 more CI jobs, I guess.
Edit: looks like we don't need whatever blocked dask
from officially supporting python=3.13
(CI seems to pass?)
Missing libraries:
dask
:dask-expr
depends onpyarrow
, which will support3.13
starting withpyarrow>=18.0
pydap
: depends onwebob
which uses the removedcgi
stdlib (see Resolve Deprecation Warnings pydap/pydap#319 (comment) in the "out-of-scope" section)numba
: as usual will take some time to support it (and thus we can't testnumbagg
andsparse
)