Fix handling of numexpr.cpu in print_versions() #495
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a couple of issues in the way "numexpr.cpu.info" is used in print_versions(): 1) all the subclasses of CPUInfoBase have a class attribute "info", whereas CPUInfoBase does not; this means that, in case there is no CPU implementation for an OS, "self.info" returns a function (because of CPUInfoBase.__getattr__()) which is not subscriptable 2) only few subclasses of CPUInfoBase (e.g. LinuxCPUInfo, Win32CPUInfo) implement "info" as list of dicts for each CPU, whereas the rest of the implementations use a dict with attributes Since "info" seems to be mostly an internal detail, then adapt print_versions() to be a little more flexible: - do not try to query attributes in case the actual CPU implementation is CPUInfoBase: it is not implemented for the current OS, so there is nothing to query anyway (fixes (1)) - get the first element of "info" only in case it is a list (fixes (2)) - drop the catch of KeyError, which should not happen anymore now
pinotree
force-pushed
the
tests-cpuinfo-usage
branch
from
a50c998
to
d698b82
Compare
|
@FrancescAlted would you please take a look at this? thanks in advance! |
|
Can you tell us what advantages that brings for users? |
|
Message to comment on stale PRs. If none provided, will not mark PRs stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of issues in the way
numexpr.cpu.infois used inprint_versions():CPUInfoBasehave a class attributeinfo, whereasCPUInfoBasedoes not; this means that, in case there is no CPU implementation for an OS,self.inforeturns a function (because ofCPUInfoBase.__getattr__()) which is not subscriptableCPUInfoBase(e.g.LinuxCPUInfo,Win32CPUInfo) implementinfoas list of dicts for each CPU, whereas the rest of the implementations use a dict with attributesSince
infoseems to be mostly an internal detail, then adaptprint_versions()to be a little more flexible:CPUInfoBase: it is not implemented for the current OS, so there is nothing to query anyway (fixes (1))infoonly in case it is a list (fixes (2))KeyError, which should not happen anymore now