Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix placeholder on text inputs #304

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix placeholder on text inputs #304

merged 1 commit into from
May 30, 2024

Conversation

sergue1
Copy link
Contributor

@sergue1 sergue1 commented May 4, 2024 •
edited by sydney-runkle

Fixes #250

@codecov Codecov
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

sydney-runkle
sydney-runkle approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks!

@sydney-runkle sydney-runkle merged commit 57815a7 into pydantic:main May 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

placeholder doesn't work on text inputs
2 participants
@sergue1 @sydney-runkle