New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance tests #2149

Open

CptGibbon opened this issue May 5, 2024 · 1 comment

Labels

help wanted testing

Collaborator

CptGibbon commented May 5, 2024

From a brief discord conversation with @gsingh93 & @disconnect3d:
Performance tests could help catch any big speed decreases introduced in a PR.

Doesn't have to be anything complicated, perhaps a benchmark of select commands with a test that shows the result before & after the PR.

Performance is somewhat subjective so we'd need to pick a threshold of what gets automatically flagged as a meaningful decrease in speed.

CptGibbon added the feature label

Member

gsingh93 commented May 5, 2024

Also from the discord discussion:

context would be a good initial command to implement this for
Maybe this action could be used: https://github.com/benchmark-action/github-action-benchmark

gsingh93 added help wanted testing and removed feature labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment