Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 59.68%. Comparing base (83d8d95) to head (cb70de1).
Report is 12 commits behind head on dev.

❗ Current head cb70de1 differs from pull request most recent head 7a04ec8. Consider uploading reports for the commit 7a04ec8 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2096      +/-   ##
==========================================
- Coverage   59.68%   59.68%   -0.01%     
==========================================
  Files         191      191              
  Lines       24429    24434       +5     
  Branches     2422     2424       +2     
==========================================
+ Hits        14581    14583       +2     
- Misses       9064     9066       +2     
- Partials      784      785       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hmm I think that ideally, we want to do this properly so that not only nearpc works fine, but other commands that would have aliases and be repeated too.

Not sure if we have such commands now, but we may in the future.

Will probably need to change something around here:

Ideally, we would only have a single command regardless of the number of aliases. But to do that I think we would need to hook GDB's command parsing look up that single command if any aliases were passed in there. I haven't looked into exactly how it would work, but I'm guessing the added complexity and bugs we'll introduce the future are probably not worth it.

Yes, I think that should work as long as from_tty=True.

@jetchirag can u update this accordingly?

@disconnect3d

u seems to already be registered as alias in gdb, rest are working fine.

for alias in self.aliases:
            alias_command = f"alias {alias} = {function.__name__}"
            gdb.execute(alias_command)
gdb.error: Alias already exists: u

Yeah it seems its fully controlled via GDB... its weird we can overwrite it as a command but not as an alias.

https://github.com/bminor/binutils-gdb/blob/3f3014cb00fabe1e340b277016a2f161ca297c71/gdb/infcmd.c#L3273-L3280

Let's close this for now.