Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade provider snapshots to v2.4.0 of provider when released #1145

Closed
rquitales opened this issue May 9, 2024 · 1 comment · Fixed by #1177
Closed

Upgrade provider snapshots to v2.4.0 of provider when released #1145

rquitales opened this issue May 9, 2024 · 1 comment · Fixed by #1177
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@rquitales
Copy link
Contributor

rquitales commented May 9, 2024

What happened?

#1136 updated the kubeconfig args to ensure that the awscli always outputs in JSON format. We'll need to update our baseline provider snapshots to account for this as our snapshot tests will always fail.

The next minor release will also contain a few other diffs related to addons, so we'll batch these updates into a single minor release to minimize state updates for the user.

In the longterm, we'd want to ignore update diffs, but error on replace diffs for scenarios like this.

Example

Output of pulumi about

Additional context

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@rquitales rquitales added the kind/bug Some behavior is incorrect or out of spec label May 9, 2024
@rquitales rquitales self-assigned this May 9, 2024
This was referenced May 9, 2024
@rquitales rquitales changed the title Upgrade provider sanpshots to v2.4.0 of provider when released Upgrade provider snapshots to v2.4.0 of provider when released May 10, 2024
@t0yv0
Copy link
Member

t0yv0 commented May 14, 2024

Self-tagging @t0yv0

rquitales added a commit that referenced this issue Jun 3, 2024
### Proposed changes

This PR switches the underlying test framework to the newer pulumitest
framework which uses Automation API under the hood. This resolves a few
pain points related to the existing upgrade tests we have, which are
extremely fragile. These changes are:

- Checking only for replacements, and ignoring diffs. This should help
resolve our snapshots constantly being out of date due to changing
upstream provider versions, or AMI IDs.
- Running preview against the cached state to reduce resource usage and
speed up the upgrade tests

### Related issues (optional)
Related: #927

Fixes: #1145
Fixes: #1174
Fixes: #1155

---------

Co-authored-by: Pulumi Bot <[email protected]>
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jun 3, 2024
flostadler pushed a commit that referenced this issue Sep 4, 2024
### Proposed changes

This PR switches the underlying test framework to the newer pulumitest
framework which uses Automation API under the hood. This resolves a few
pain points related to the existing upgrade tests we have, which are
extremely fragile. These changes are:

- Checking only for replacements, and ignoring diffs. This should help
resolve our snapshots constantly being out of date due to changing
upstream provider versions, or AMI IDs.
- Running preview against the cached state to reduce resource usage and
speed up the upgrade tests

### Related issues (optional)
Related: #927

Fixes: #1145
Fixes: #1174
Fixes: #1155

---------

Co-authored-by: Pulumi Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
3 participants