Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of suppress.CaseDifferenceV2Only #2052

Closed
danielrbradley opened this issue May 21, 2024 · 1 comment
Closed

Remove use of suppress.CaseDifferenceV2Only #2052

danielrbradley opened this issue May 21, 2024 · 1 comment
Assignees
Labels
impact/reliability Something that feels unreliable or flaky kind/engineering Work that is not visible to an external user resolution/duplicate This issue is a duplicate of another issue

Comments

@danielrbradley
Copy link
Member

danielrbradley commented May 21, 2024

This is split between 0004-fixup-Shared-features.patch and 0005-Modify-resources.patch.

History:

  1. Originally introduced in Provider - Add the missing suppress.CaseDifference for case-insensitive string properties hashicorp/terraform-provider-azurerm#15182
  2. Customised by Stack72
  3. Removed in Refactor: Remove all usages of ThreePointOhBeta hashicorp/terraform-provider-azurerm#16812
  4. Tweaked comment by JK

Function code:

// CaseDifferenceV2Only only suppress case difference for v2.0.
func CaseDifferenceV2Only(_, old, new string, _ *schema.ResourceData) bool {
	// FORK: Force attributes to maintain case-insensitivity to avoid breaking changes in Pulumi programs.
	return strings.EqualFold(old, new)
}
@danielrbradley danielrbradley added impact/reliability Something that feels unreliable or flaky kind/engineering Work that is not visible to an external user labels May 21, 2024
@danielrbradley danielrbradley self-assigned this May 23, 2024
@danielrbradley danielrbradley added the resolution/duplicate This issue is a duplicate of another issue label May 23, 2024
@danielrbradley
Copy link
Member Author

Merged into #2051

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/reliability Something that feels unreliable or flaky kind/engineering Work that is not visible to an external user resolution/duplicate This issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

1 participant