Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Setting to add bezels to "Responsive Design Mode" #263

Open
zzAIMoo opened this issue Jul 13, 2023 · 1 comment
Open

[enhancement] Setting to add bezels to "Responsive Design Mode" #263

zzAIMoo opened this issue Jul 13, 2023 · 1 comment

Comments

@zzAIMoo
Copy link

zzAIMoo commented Jul 13, 2023

I'm not sure it's possible since i've never looked at the source code of neither firefox or pulse, but i was thinking of adding a button in the Responsive Design Mode (Mobile View accessible from the devtools) that would add bezels just like those present in the physical counterpart of the simulators. If anyone can give me some directions on where i could find the files that manage the Responsive Design Mode i would be more than happy to try implement this feature

@zzAIMoo zzAIMoo changed the title Setting to add bezels to "Responsive Design Mode" [enhancement] Setting to add bezels to "Responsive Design Mode" Jul 13, 2023
@trickypr
Copy link
Member

Some pointers:

  1. In Pulse (and, with some settings changes, in Firefox), you can open browser-wide devtools (known as the browser toolbox) by pressing Ctrl + Alt + Shift + I. This might be helpful for debugging stuff.
  2. Responsive design has an initialization and destruction section.
  3. I would recommend against touching the JS code if you can avoid it. Instead try writing a userchrome file. These are custom css files that apply to the browser UI. They are slightly more maintainable than JS changes.
  4. If you don't want to worry about compiling Pulse, add your userchrome file to this folder, open a PR and ping me. I will hook it up and test it
  5. You probably want to look into styling .responsive-mode and its children.
  6. There isn't any attributes that represent the device type. I can add them if you want, ping me in discord if so

If you want to talk to me, come join the Discord server and say hi. Good luck :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants