-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR CI statuses not fully in sync #484
Comments
Just noticed 1.8.5 is out. I am going to test it and report if the issue occurs in this version too |
Hi, thanks for raising 👍 I suspect the issue will be on the newer versions as well, as I haven't touched anything there (unless I did it by mistake :D) - I suspect this may have to do with the filtering occurring before the final status "stack" is assembled. The reason a full sync probably fixes this is because it only queries the statuses "shallowly" so the history that was being shown there (erroneously) probably never makes it to the local DB. Question: This info isn't from a public repo, is it? Always helpful if I can try reproducing issues on the same data-set if at all possible :) |
It's a private repo which, unfortunately, I cannot share access to. If there is any other way to help with debugging, please let me know. I really appreciate Trailer app and all your effort. |
No worries at all, but always worth me asking on such occasions :) I'll dig into this soon and update you 👍 |
I noticed that statuses for my repository are not always in sync.
On Github Pull Request page you can see that all checks passed:
![image](https://private-user-images.githubusercontent.com/26869324/259942156-532db923-e3e4-4ea8-ac36-8915bbfa67d6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg2OTU0NTQsIm5iZiI6MTcxODY5NTE1NCwicGF0aCI6Ii8yNjg2OTMyNC8yNTk5NDIxNTYtNTMyZGI5MjMtZTNlNC00ZWE4LWFjMzYtODkxNWJiZmE2N2Q2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDA3MTkxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMxMDBkMjZmNTdlOTY1ODEwYTg4NTliZDkxYjMxMjQzZTU1MDZhMjIyZjYwNDZkOGQ0ODc2MjNmMGFlMzFmOTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.W66XIswpCDMFIzdw7W1vpxOBOL6bDY5CN7YcXFJMgfU)
In Trailer 1.8.4 on Mac OS (fewer positions here as I use "Exclude status items that include any of the terms below" filtering):
![image](https://private-user-images.githubusercontent.com/26869324/259943023-6a421e63-5abd-40d5-95ac-2933c79318c9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg2OTU0NTQsIm5iZiI6MTcxODY5NTE1NCwicGF0aCI6Ii8yNjg2OTMyNC8yNTk5NDMwMjMtNmE0MjFlNjMtNWFiZC00MGQ1LTk1YWMtMjkzM2M3OTMxOGM5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDA3MTkxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTFmYjFiNDlhNTk0NWUwNjJjOTU5MTdkMmMzMzk2ODhiOTcxOTkxM2QzYmZiOTQ5YTc3M2VjYWI4NGUwMWM3YzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.IY8JFGWBFKMiBYQ1dlqZCvcvlAeJr0aMV1Ox9TOJ6Hs)
the statuses are sometimes neutral, sometimes green.
I expect all of them to be green when on Github these are green too.
Doing refresh from the menu does NOT help.
![image](https://private-user-images.githubusercontent.com/26869324/259942742-71d4f080-6128-4bc9-a758-ce11295a74b2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg2OTU0NTQsIm5iZiI6MTcxODY5NTE1NCwicGF0aCI6Ii8yNjg2OTMyNC8yNTk5NDI3NDItNzFkNGYwODAtNjEyOC00YmM5LWE3NTgtY2UxMTI5NWE3NGIyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDA3MTkxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlhNGMwMjY4M2VlODM1ZjdjMWE4YzVhMTllNGNjZmRkZTkxYTQ2Y2M4MzJmMjYyZGU3NTNmODM3YTIxZThkMDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Ll3IjNYqyoHD9Hnm5nLJptPtWzFrh4uDqoG0KqEPyrs)
But doing full sync properly synchronises the statuses:
![image](https://private-user-images.githubusercontent.com/26869324/259942822-b7b2290d-8cc3-4d7b-bbed-15075bfcff32.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg2OTU0NTQsIm5iZiI6MTcxODY5NTE1NCwicGF0aCI6Ii8yNjg2OTMyNC8yNTk5NDI4MjItYjdiMjI5MGQtOGNjMy00ZDdiLWJiZWQtMTUwNzViZmNmZjMyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDA3MTkxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQwOTI2ZjI1MjQxMDRjMzU2M2YyY2QyODY3ZWNlZmQ2YjlkNTkyNjYzMTk3YjMwOTZlNDFhNTM2YWJkZTE4MWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0._VQywuMM-iEUrWl9lnS8BfuN7Do0d51zI6OqsOIWmtU)
![image](https://private-user-images.githubusercontent.com/26869324/259942847-b2850e01-bc9e-450d-8d33-af969557f80c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg2OTU0NTQsIm5iZiI6MTcxODY5NTE1NCwicGF0aCI6Ii8yNjg2OTMyNC8yNTk5NDI4NDctYjI4NTBlMDEtYmM5ZS00NTBkLThkMzMtYWY5Njk1NTdmODBjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE4VDA3MTkxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNkYTU0ZjFkYzc4NTE2NmE3NTMwMjg0ZmIzMGExZTkzYzMxMTc2ZGVhZDcwMGExNjQ4ODhhYThjMDg1OGQ5MTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rE2kkwnFrElyu_oINaajZ4rxlddAJ1ZpL4IcMQ9K0Xo)
The text was updated successfully, but these errors were encountered: