Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling external API calls #4393

Open
2 tasks done
PreNoob opened this issue Mar 1, 2024 · 3 comments · Fixed by kafbat/kafka-ui#185
Open
2 tasks done

Allow disabling external API calls #4393

PreNoob opened this issue Mar 1, 2024 · 3 comments · Fixed by kafbat/kafka-ui#185
Labels
status/triage Issues pending maintainers triage type/feature A new feature

Comments

@PreNoob
Copy link

PreNoob commented Mar 1, 2024

Issue submitter TODO list

  • I've searched for an already existing issues here
  • I'm running a supported version of the application which is listed here and the feature is not present there

Is your proposal related to a problem?

Currently the start up is delayed by 10 seconds and runs into an io.netty.handler.ssl.SslHandshakeTimeoutException when trying to call api.github.com which fails due to the restriction of external calls from the cluster.

Describe the feature you're interested in

Please provide a configuration parameter that allows disabling all external API calls which should result in not querying the GitHub release info and potential other external API calls in the future.

This could be possible by disabling the instantiation here.

Describe alternatives you've considered

No response

Version you're running

56fa824

Additional context

I would be open to contributing this feature, if desired.

@PreNoob PreNoob added status/triage Issues pending maintainers triage type/feature A new feature labels Mar 1, 2024
@Haarolean
Copy link
Contributor

This can't affect startup time, as it's a non-blocking call and it's not executed upon a start

@PreNoob
Copy link
Author

PreNoob commented Mar 1, 2024

I inferred that it is called at startup from this comment.

Is there any other place api.github.com is called?
My feature request would still be the same.

@Haarolean
Copy link
Contributor

Thanks, I've followed the call chain from your original message which had no blocking calls.
The new link, however, does that, as a combination of a @Scheduled annotation which will lead to a call performed right after the context initialization, plus a blocking call for a mono gives us exactly that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/triage Issues pending maintainers triage type/feature A new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants