-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeepCase should default to true #1964
Comments
I understand where you are coming from. Both decisions (either Changing the default will be a big breaking change and a lot of code will stop working, so I don't think we should do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
protobuf.js version: latest
Keep case defaults to false. This results in the default being to violate protobuf contracts until explicitly told not to. It is not protobuf.js's job to conform to casing opinions, rather to comply with the proto files provided to it. If a non camel case item exists, it should be respected. Otherwise protobuf.js is simply violating a contract just because it's not camelCase.
I'm happy to make this change if the maintainers allow it.
Edit: Here's a reference to the default
protobuf.js/src/parse.js
Line 5 in 2f846fe
The text was updated successfully, but these errors were encountered: