-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store _pronamic_payment_key
in JSON
#237
Comments
For now decided to simply use: payment {
"key": "..."
} |
remcotolsma
added a commit
to pronamic/wp-pay-core
that referenced
this issue
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@rvdsteege How should we name this in JSON?
Is just
key
clear enough?$payment->get_key()
$payment->set_key( $key )
Or should we put this away in
meta
? Did we borrow the concept of akey
from WooCommerce orders?In #201 (comment) i also describe a rewrite rule like:
Also with the note:
In https://docs.google.com/spreadsheets/d/1CJHnHcr9s8lkh4Fq9HQmlAThCK69eXiTC3UktyeQKYw/edit?usp=sharing we also suggested to store the
key
inwp_posts.post_password
.There is no index on the
wp_posts.post_password
so maybewp_posts.post_name
is even a better choice?The current payment/subscription key is also not a
wp_hash( $subscription->get_id() )
key.The text was updated successfully, but these errors were encountered: