Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8: Implement support in Rust client library #190

Open
4 tasks
Tracked by #13095
ywwg opened this issue Mar 5, 2024 · 3 comments
Open
4 tasks
Tracked by #13095

UTF-8: Implement support in Rust client library #190

ywwg opened this issue Mar 5, 2024 · 3 comments
Assignees
Labels
help wanted Extra attention is needed priority/P3

Comments

@ywwg
Copy link
Member

ywwg commented Mar 5, 2024

As in prometheus/client_golang#1369 and prometheus/client_java#916, the Rust client library needs to be updated to support UTF-8.

Tasks:

  • Add flag to enable change in validation logic to check that metric and label names are UTF-8 valid instead of the old letters/numbers/underscores/colons set
  • Update exposition format parsers for the new syntax
  • Update PromQL parsers (if any) for the new syntax
  • Update content negotiation logic

For background and references see prometheus/prometheus#13095

@ywwg ywwg changed the title UTF-8: Implement support in Ruby client library UTF-8: Implement support in Rust client library Mar 5, 2024
@fionaliao fionaliao added the help wanted Extra attention is needed label Aug 13, 2024
@shashank-priyadarshi
Copy link

@ywwg I would like to take this up.

@fedetorres93
Copy link

fedetorres93 commented Oct 7, 2024

@shashank-priyadarshi Thanks! I'm making progress on this already on my end

@ywwg
Copy link
Member Author

ywwg commented Oct 7, 2024

Yes sorry I am unable to assign Fede on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed priority/P3
Projects
Status: Todo
Development

No branches or pull requests

4 participants