-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metrics without labels missing breaks some codepath #949
Comments
I've tried to add a This fixes the problem, but the Not sure how to properly fix this, or if this is even desirable |
You could use e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When initialized without labels, it seems that the resulting metrics objects will lack some instance variables.
Minimal example:
The same code with declared labels will properly clear the metrics data
I came up upon this when adding a new metric and forgetting to add the labels.
(I'm using
.clear()
to reset the metrics during tests)The text was updated successfully, but these errors were encountered: