Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide further breakdown of "processing" phase metric (for oauth2 probes) #1156

Open
nemobis opened this issue Nov 21, 2023 · 0 comments
Open

Comments

@nemobis
Copy link

nemobis commented Nov 21, 2023

We're using the oauth2 module for some probes (see also #1155) and occasionally they're very slow. We're not sure in what phase the slowness is happening, except that it's in the processing phase (probe_http_duration_seconds{phase="processing"}).

It would be nice to (optionally?) provide a further breakdown of the processing phase, or maybe just an additional gauge to measure how long it takes to do the oauth2 handshake.

For a separate gauge, a good point might be the line where NewClientFromConfig is invoked. As for the current durationGaugeVec, it extracts information from httptrace.ClientTrace and I'm not sure that can be broken down further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant