-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "Menu" to "MenuItem" #67
Comments
The existence of YoshiTableViewMenu complicates things, because it already has an associated protocol called YoshiTableViewMenuItem. On the other hand, that name itself is confusing, because it's a very specific kind of table view (allowing you to select one of several options) and that's not reflected by the name — in fact, it being a table view is really just an implementation detail, not the primary characteristic. Here's what I propose: YoshiTableViewMenu becomes YoshiPickerMenuItem |
These names are somewhat inherited from 1.0 and gets expanded, for backward-compatibility concern the name will stay the same in the foreseeable future, we may change the name in the next major breaking update. |
The name Menu is confusing — it sounds like a screenful of options. Most classes/protocols/etc in Yoshi ending with the word "Menu" actually represent individual menu items, I.E. cells. YoshiGenericMenu should be YoshiGenericMenuItem, etc.
The text was updated successfully, but these errors were encountered: