Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse animation speed #32

Open
ValiDraganescu opened this issue May 24, 2020 · 11 comments
Open

Collapse animation speed #32

ValiDraganescu opened this issue May 24, 2020 · 11 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ValiDraganescu
Copy link

Hi, I am using atomize for a toy project. I noticed that the collapse atom is not very snappy in it's animation, I'd like to speed up the animation. How to do this? Thank you!

@ValiDraganescu
Copy link
Author

In Collapse.js I see

render() {
    const { defaultHeight } = this.state;
    const { p, children, isOpen, ...rest } = this.props;

    /**
     * Duration for the transition
     */
    const duration = 400;
...

This means the duration is hardcoded?

@proksh
Copy link
Owner

proksh commented Jun 30, 2020

Yes @ValiDraganescu, It is hardcoded right now. I will soon update it in the next version, for custom transitions.

@proksh proksh added enhancement New feature or request good first issue Good for newcomers labels Jun 30, 2020
@ValiDraganescu
Copy link
Author

I ended up copying Collapse.js and modifying per my needs, it works for now

@proksh
Copy link
Owner

proksh commented Jun 30, 2020

Great @ValiDraganescu

@bobbylemm
Copy link

@proksh I would like to know if this issue has been fixed

@LucaMoro96
Copy link

@bobbylemm Not yet!

@bobbylemm
Copy link

@LucaMoro96 can I work on this

@LucaMoro96
Copy link

@bobbylemm Sure!

@bobbylemm
Copy link

Alright great

@manan1979
Copy link

hi @ValiDraganescu can i work on this?

@ValiDraganescu
Copy link
Author

Hi @manan1979 , this is not my repo, I see others above offering to work on this one, so maybe check with @bobbylemm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants