Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate new metric engine performance #1344

Open
akoshelev opened this issue Oct 10, 2024 · 2 comments
Open

Evaluate new metric engine performance #1344

akoshelev opened this issue Oct 10, 2024 · 2 comments

Comments

@akoshelev
Copy link
Collaborator

I want to see whether using thread-local storages actually improves query performance
@akoshelev
Copy link
Collaborator Author

I had to fix #1345 first because it turned out we've been running with global metric collector all the time, but after turning it off I got some numbers I can share here

@akoshelev
Copy link
Collaborator Author

akoshelev commented Oct 15, 2024 •
edited
Loading

Overall the impact of using the old metric engine seems to be around 10%. For 1M input, it takes 10 mins with metrics enabled and 9 mins with metrics disabled. The new metric engine does not seem to have any impact on runtime

Input size\Time (s) No metrics Metrics V1 (old) Metrics V2 (new)
1M 548 609 548
10M 10600 11160 10585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akoshelev