Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit tests passing when CI fails #1224

Open
bmcase opened this issue Aug 15, 2024 · 0 comments
Open

pre-commit tests passing when CI fails #1224

bmcase opened this issue Aug 15, 2024 · 0 comments

Comments

@bmcase
Copy link
Member

bmcase commented Aug 15, 2024

I've had it happen a couple times where a test will pass in the pre-commit stage but then the same test will fail when running in the CI.

I can recreate the test failing locally like in the CI if I run it with release and a feature flag. Here is an example:

cargo test --release --lib protocol::ipa_prf::tests::semi_honest_degenerate --features "shuttle multi-threading"

My question is if we should update the pre-commit tests to more exactly capture these scenarios that are run in the CI check.yml?

In particular the CI (check.yml) seems to run the concurrency tests (which is where I've seen all these occur) but it seems the pre-commit does not.

      - name: Run concurrency tests
        run: cargo test --release --features "shuttle multi-threading"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant