We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I've had it happen a couple times where a test will pass in the pre-commit stage but then the same test will fail when running in the CI.
I can recreate the test failing locally like in the CI if I run it with release and a feature flag. Here is an example:
cargo test --release --lib protocol::ipa_prf::tests::semi_honest_degenerate --features "shuttle multi-threading"
My question is if we should update the pre-commit tests to more exactly capture these scenarios that are run in the CI check.yml?
pre-commit
check.yml
In particular the CI (check.yml) seems to run the concurrency tests (which is where I've seen all these occur) but it seems the pre-commit does not.
- name: Run concurrency tests run: cargo test --release --features "shuttle multi-threading"
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I've had it happen a couple times where a test will pass in the pre-commit stage but then the same test will fail when running in the CI.
I can recreate the test failing locally like in the CI if I run it with release and a feature flag. Here is an example:
cargo test --release --lib protocol::ipa_prf::tests::semi_honest_degenerate --features "shuttle multi-threading"
My question is if we should update the
pre-commit
tests to more exactly capture these scenarios that are run in the CIcheck.yml
?In particular the CI (
check.yml
) seems to run the concurrency tests (which is where I've seen all these occur) but it seems the pre-commit does not.The text was updated successfully, but these errors were encountered: