Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Points to reconcile between MAC and DZKP malicious APIs #1219

Open
2 of 5 tasks
andyleiserson opened this issue Aug 9, 2024 · 0 comments
Open
2 of 5 tasks

Points to reconcile between MAC and DZKP malicious APIs #1219

andyleiserson opened this issue Aug 9, 2024 · 0 comments

Comments

@andyleiserson
Copy link
Collaborator

andyleiserson commented Aug 9, 2024

  • Whether or not an atomic integer is used to count pending records in a batch
  • MAC implementation stores offset within each batch, which means it doesn't need the offset when validate_record returns a batch to be validated. Possibly DZKP can do this as well?
  • MAC batcher implementation is still using Notify, doesn't have the stuff to communicate Error::ParallelDZKPValidationFailure.
  • Code duplication between DZKP and MAC validators - the logic to cancel pending futures when validation fails should be unified
  • Test that API can interop with seq_join (try_join). I noticed that test runs that include more than one record id hang, if one validate fails. try_join_all works, ctx.try_join does not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant