Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/rest nextjs api routes #4975

Open
wants to merge 7 commits into
base: latest
Choose a base branch
from
Open

Enhance/rest nextjs api routes #4975

wants to merge 7 commits into from

Conversation

mayank1513
Copy link
Contributor

@mayank1513 mayank1513 commented Jul 21, 2023 •
edited
Loading

Fixes #4974

Refractor code to match community standards

  • Remove unnecessary React.FC syntax
  • Extract Layout to _app.tsx (No need to add layout on every page)
  • Use absolute path uniformly - remove import ../.., etc.

Update UI to reflect functionality properly

  • SignUp button should be renamed to "Add Author"
  • /signup route should be renamed to /add-author
  • On create post page, email input should be changed to select (As only those emails that exists in users table can be added there)
  • Remove legacyBehaviour and update links

@mayank1513
Refractor
992cf63 
Refractor code to match community standards
- Removed unnecessary React.FC syntax from components folder
- update .gitignore to ingore package-lock files
@mayank1513
Refractor
87779a3 
Refractor code to match community standards
- Extract Layout to _app.tsx
@mayank1513
Uniformly use absolute path with aliases
2dd5cb9 
- removed long `../..` pattern
- makes refactoring/rearranging files easy
@mayank1513
Refractor
ac01f3b 
Refractor code to match community standards
- Removed unnecessary React.FC syntax from pages
@mayank1513
Clarify presentation
54f510d 
- There is no login or signup mechanism.
- Signup button adds new author
- This commit simply renames UI text to reflect that more clearly
@mayank1513
Change AuthorEmail TextBox to Select
e485fa0 
- Change authorEmail Input field to select
- This is much better as Author email must exist in users table
- fix imports
@mayank1513
Remove Legacy behaviour
b6c9a24 
- fixes prisma#4974
@mayank1513 mayank1513 closed this Jul 21, 2023
@mayank1513 mayank1513 reopened this Jul 21, 2023
@mayank1513
Copy link
Contributor Author

image

@mayank1513
Copy link
Contributor Author

Hi,

anybody here?

@mayank1513
Copy link
Contributor Author

Is this repo deprecated?

@jharrell jharrell requested review from jharrell and ruheni December 18, 2023 15:46
@jharrell
Copy link
Member

Hi there! Apologies for not seeing this back when you opened it. I tried my hand at fixing merge conflicts and failed spectacularly. If you're still interested in this, would you mind correcting the merge conflicts? I will then give this the go ahead.

@jharrell
Copy link
Member

Hello!

We are reviewing our old pull requests in this repo. If we believe that the PR is stale or abandoned, we're going to close them.

We'd still love to have your contribution! If you'd be willing to pick this PR back up, please just comment or open a new pull request and we'll hop on it 🙏

@jharrell jharrell closed this Dec 20, 2024
@mayank1513
Copy link
Contributor Author

hi

@jharrell jharrell reopened this Dec 20, 2024
@jharrell jharrell removed the request for review from ruheni December 20, 2024 18:14
@jharrell
Copy link
Member

Hi @mayank1513 and glad to have you back 😊

I'll take a look at resolving merge conflicts, but as our codebase has changed pretty significantly it might be difficult. Please bear with me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharrell jharrell Awaiting requested review from jharrell

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Next.js Rest API example
2 participants
@mayank1513 @jharrell