Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] Popover: Arrow offset uses wrong design token #5755

Closed
m-meier opened this issue May 17, 2024 · 1 comment
Closed

[v4] Popover: Arrow offset uses wrong design token #5755

m-meier opened this issue May 17, 2024 · 1 comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
4.0.0-beta.4

Comments

@m-meier
Copy link
Contributor

m-meier commented May 17, 2024

Describe the bug

The PopoverStyle.js uses the "popover.arrow.left" design token to position the arrow when the popup reaches the screen border. However the Popover component sets the "overlay.arrow.left" design token in the alignOverlay method.

Therefore the arrow is never repositioned.

Reproducer

https://stackblitz.com/edit/vitejs-vite-rameuq?file=src%2FApp.vue

PrimeVue version

4.0.0-beta.3

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Add a button with a popover which is limited by the right side and therefore pushed to the left.

Expected behavior

Arrow should be placed in the correct spot and use the correct design token.
@m-meier m-meier added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 17, 2024
m-meier added a commit to m-meier/primevue that referenced this issue May 17, 2024
@m-meier
Popover: use correct design token for arrow positioning, fixes primef…
e4d899b 
…aces#5755
@m-meier m-meier mentioned this issue May 17, 2024
Merged
mertsincan pushed a commit that referenced this issue May 17, 2024
@m-meier
Popover: use correct design token for arrow positioning, fixes #5755 (#…
5b3efec 
…5756)
@mertsincan mertsincan added this to the 4.0.0-rc.1 milestone May 17, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 17, 2024
@mertsincan
Copy link
Member

Good catch! Thanks a lot for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
4.0.0-beta.4
Development

No branches or pull requests
2 participants
@m-meier @mertsincan