-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataTable with Virtual Scroller and Multiselect; onSelectionChanged provides incorrect selections and [...undefined, undefined, ...] #6791
Closed
nikcich opened this issue
Jun 25, 2024
· 2 comments
· Fixed by leoo1992/GeradorQRCode#57 or #6985 · May be fixed by nhattpn/BTL_LTNC#56
Closed
DataTable with Virtual Scroller and Multiselect; onSelectionChanged provides incorrect selections and [...undefined, undefined, ...] #6791
nikcich opened this issue
Jun 25, 2024
· 2 comments
· Fixed by leoo1992/GeradorQRCode#57 or #6985 · May be fixed by nhattpn/BTL_LTNC#56
Comments
nikcich
added
the
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
label
Jun 25, 2024
melloware
added
Type: Bug
Issue contains a defect related to a specific component.
and removed
Status: Needs Triage
Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
labels
Jun 25, 2024
Same as #5870 ? |
I saw that issue (5870) prior to submitting this one. Definitely a similar problem. At the very least, my issue has the added fact that it selects incorrect rows in addition to others being undefined. |
kl-nevermore
added a commit
to kl-nevermore/primereact
that referenced
this issue
Aug 5, 2024
…onSelectionChanged provides incorrect selections
melloware
pushed a commit
that referenced
this issue
Aug 5, 2024
…nChanged provides incorrect selections (#6985)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
This is sort of 2 problems, both related to the Shift+Click row selection.
2024-06-24.19-07-56.mp4
2024-06-24.19-08-59.mp4
I have also seen both of these issues happen together (I believe the second video shows this)
Reproducer
https://stackblitz.com/edit/vitejs-vite-to2pri?file=src%2FApp.jsx
PrimeReact version
10.6.5
React version
18.x
Language
ES6
Build / Runtime
Vite
Browser(s)
No response
Steps to reproduce the behavior
Click select a row (e.g. the row 0)
Scroll down a number of "pages" so the virtual scroller loads more data
Shift+Click to select up to and including another row (e.g. row 150)
Observe the console.log values and what is visually shown as being selected in the table
Expected behavior
I would expect the onSelectionChanged callback to return an accurate list of selected rows, and not to have any rows undefined.
The text was updated successfully, but these errors were encountered: