Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Ripple needs to be enable, docs says false #5316

Closed
Dalorzo opened this issue Nov 14, 2023 · 0 comments · Fixed by #5318
Closed

Documentation: Ripple needs to be enable, docs says false #5316

Dalorzo opened this issue Nov 14, 2023 · 0 comments · Fixed by #5318
Assignees
@melloware
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
10.1.0

Comments

@Dalorzo
Copy link
Contributor

Dalorzo commented Nov 14, 2023 •
edited
Loading

Describe the bug

Docs says regarding enabling Ripple:

To start with, Ripple needs to be enabled globally. However, value says ripple: false, when I think the correct should be true

image

Reproducer

No response

PrimeReact version

10.0.9

React version

18.x

Language

ALL

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@Dalorzo Dalorzo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 14, 2023
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 14, 2023
@melloware melloware self-assigned this Nov 14, 2023
@melloware melloware added this to the 10.0.10 milestone Nov 14, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 14, 2023
@melloware
Fix primefaces#5316: Ripple docs
b746f3c
@melloware melloware mentioned this issue Nov 14, 2023
Merged
melloware added a commit that referenced this issue Nov 14, 2023
@melloware
Fix #5316: Ripple docs (#5318)
99f405e
@NikVAx NikVAx mentioned this issue Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
10.1.0
Development

Successfully merging a pull request may close this issue.

Fix #5316: Ripple docs melloware/primereact
2 participants
@melloware @Dalorzo