Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumer: PageSpeed Accessibility: ARIA IDs are unique #5270

Closed
zawasp opened this issue Nov 10, 2023 · 4 comments · Fixed by #5280
Closed

InputNumer: PageSpeed Accessibility: ARIA IDs are unique #5270

zawasp opened this issue Nov 10, 2023 · 4 comments · Fixed by #5280
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@zawasp
Copy link
Contributor

zawasp commented Nov 10, 2023

Describe the bug

The span and input used to compose the InputButton have the same ARIA IDs:

image

Reproducer

No response

PrimeReact version

10.0.9

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

The span and input used to compose the InputButton should have different ARIA IDs:

@zawasp zawasp added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 10, 2023
@melloware
Copy link
Member

I can't reproduce:

<InputNumber id="test1" inputId="test2" value={value1} onValueChange={(e) => setValue1(e.value)} />

Makes the SPAN and INPUT have correct ID's?

image

@melloware melloware added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 10, 2023
Copy link

We're unable to replicate your issue, if you are able to create a reproducer or add details please edit this issue. This issue will be closed if no activities in 20 days.

@zawasp
Copy link
Contributor Author

zawasp commented Nov 10, 2023

Ok, in my case both id and inputId had the same value, so that's why. Maybe put that in docs as it's not mentioned at https://primereact.org/inputnumber/#accessibility

@melloware
Copy link
Member

Oh got it yeah that is why the id's are separate so you can assign them separately and independently especially for ARIA and automated testing tools. Let me add some docs.

@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Resolution: Cannot Replicate Issue could not be replicated by Core Team labels Nov 10, 2023
@melloware melloware self-assigned this Nov 10, 2023
@melloware melloware added this to the 10.0.10 milestone Nov 10, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 10, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants