Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Picklist: Documentation #4887

Closed
SoyDiego opened this issue Sep 6, 2023 · 0 comments · Fixed by #4886
Closed

Picklist: Documentation #4887

SoyDiego opened this issue Sep 6, 2023 · 0 comments · Fixed by #4886
Assignees
@SoyDiego
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
10.0.0

Comments

@SoyDiego
Copy link
Contributor

SoyDiego commented Sep 6, 2023 •
edited
Loading

Describe the bug

The current documentation is adding sourceStyle={{ height: '30rem' }} targetStyle={{ height: '30rem' }} but is doing nothing because we have a max-height: 24rem.

image

image

Reproducer

No response

PrimeReact version

Last version

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

Check in https://primereact.org/picklist/

Expected behavior

Update the docs to the correcct value
@SoyDiego SoyDiego added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 6, 2023
@SoyDiego SoyDiego mentioned this issue Sep 6, 2023
Merged
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 7, 2023
@melloware melloware added this to the 10.0.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoyDiego SoyDiego

Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

docs: Changed Height Picklist component SoyDiego/primereact
2 participants
@melloware @SoyDiego