-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the default
feature to base
#1416
Comments
Furthermore, the naming meaning of |
I don't think the environment should be named However, this change would make more sense to me for the default feature. This is used as a basis for all environments and has to be deactivated by adding That said we've chosen for "default" as it is what |
🤦🏻♂️ Sorry for my incorrect description. It should be the feature,not the env. |
default
environment to base
default
feature to base
I suggest we keep this open for a while to see how others feel about it :) As it would be a breaking change. |
I feel like default is a pretty good name even for the feature:
|
You can think of Or in the OOP inheritance, we refer to it as a That's why like |
Just stumbled upon that issue. My take on that: On the other hand newcomers could confuse the concept of "base feature" with the conda "base environments". To me it doesn't feel like the potential improvements isn't worth the breaking change and therefore the migration efforts people have to do. |
As it's pretty stale and most people I discussed this with have the same opinion as @dennis-wey. I'm going to close this. |
Problem description
Currently, we use
default
as the base feature name, but this can lead to some ambiguities.Some features want to inherit
[pypi-option]
fromdefault
feature, but not[dependencies]
from it, and if we useno-default-feature
, then it will exclude all options fromdefault
feature.So we should rename
default
tobase
, all default configurations should under[project]
(like channels, pypi-options, system-requirements), so whether it is the base feature or other features, they default to use the[project]
configuration, which of course can be overwritten in its own feature section.The text was updated successfully, but these errors were encountered: