Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for monorepos #37

Open
Meemaw opened this issue Aug 26, 2020 · 2 comments
Open

Better support for monorepos #37

Meemaw opened this issue Aug 26, 2020 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@Meemaw
Copy link

Meemaw commented Aug 26, 2020

In a monorepo one might use multiple actions on a PR to report changes on different modules.

  • If using comments, each of those actions will override/"update" the previous comment.
  • If using "use-check" the behaviour is wrong as well

Proposed solution:

  • Introduce an input that will dedup those comments (e.g. label or something). One could pass label="App 1", label="App2" (this could also be displayed in the final markdown for better UI/UX) which would additionally be used to dedup the comments.
@developit
Copy link
Member

Wouldn't it be better to have a single action calculate and size diffs for all files in the monorepo?

@developit developit added enhancement New feature or request question Further information is requested labels Dec 18, 2020
@frassinier
Copy link

Agreed with @developit,
if you use Lerna, for example, you just have to include all packages using pattern

          pattern: './packages/*/dist/*.{js,css}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants