Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module info and fix build for Java 9 #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vatbub
Copy link
Contributor

@vatbub vatbub commented Oct 12, 2021

Hi Pratanu :)
I recently upgraded all my projects to the latest Java version including the introduction of modules in Java 9. To make a long story short: I had to create module-info.java files for all of my dependencies and thought to share that with you.

Before you merge though: Merging this PR makes Unique4J incompatible with Java 6, 7 and 8 and requires Java 9 or higher. If you don't care about that feel free to merge. If you do care, I would suggest to create 2 jars: One that includes the module-info.java, making Java9 users happy and one that doesn't, making support for Java 8 and lower possible.

Feel free to contact me if you have any questions :)
Cheers,
Vatbub

@prat-man
Copy link
Owner

prat-man commented Dec 1, 2021

Hi Frederik,

I apologize for the delay in my action.
I thank you for your support and continued contribution to the project. It means a lot to me personally.

However, I do want to maintain compatibility starting from Java 1.6+ if possible. I will look into the solution to maintain separate builds of the project to provide support for Java 6, 7, and 8 as well as Java 9+.

Once again thank you for your contribution.

Best Regards,
Pratanu Mandal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants