Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected \n in compact output #406

Closed
lanodan opened this issue Aug 12, 2021 · 1 comment
Closed

Unexpected \n in compact output #406

lanodan opened this issue Aug 12, 2021 · 1 comment
Assignees

Comments

@lanodan
Copy link

lanodan commented Aug 12, 2021

Might this be caused by the cheating mentionned briefly in #391 (comment)? (I'm also a Pleroma dev btw)

For example with Earmark.as_html!("hello\nworld", compact_output: true), earmarks renders it as "<p>hello\nworld</p>" while it should end up as "<p>hello world</p>".

CommonMark "Soft line breaks" section seems relevant: https://spec.commonmark.org/0.30/#soft-line-breaks

@RobertDober
Copy link
Collaborator

IIRC there is no difference in the semantics of the both,correct?
We are not at all aiming to be Common Mark compatible.

I will have a look if this is an easy fix though.

@RobertDober RobertDober self-assigned this Aug 28, 2021
@RobertDober RobertDober added this to the 1.4.17 milestone Oct 16, 2021
RobertDober added a commit that referenced this issue Oct 27, 2021
RobertDober added a commit that referenced this issue Oct 27, 2021
github-actions bot pushed a commit to kphrx/pleroma that referenced this issue Nov 16, 2021
This should fix the presence of extraneous newlines in markdown output.

Related: pragdave/earmark#406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants