New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Vumi codecs for outbound SMPP messages. #1019

Open

hodgestar opened this issue Nov 24, 2015 · 1 comment

Contributor

hodgestar commented Nov 24, 2015

We have special support for GSM 03.38 and UCS2 codecs for inbound SMPP messages, but we don't provide these for outbound SMPP messages currently.

Contributor Author

hodgestar commented Nov 24, 2015

The inbound SMPP message processor (DeliverShortMessageProcessor) sets up a Vumi codec class at https://github.com/praekelt/vumi/blob/develop/vumi/transports/smpp/processors/default.py#L253 and uses it at https://github.com/praekelt/vumi/blob/develop/vumi/transports/smpp/processors/default.py#L288.

The outbound SMPP message processor (SubmitShortMessageProcessor) should do the equivalent. We will need to replace https://github.com/praekelt/vumi/blob/develop/vumi/transports/smpp/processors/default.py#L510.

We will also need a test that GSM 03.38 works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment