-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen "partially-approved" conditions #246
Comments
That makes sense. If there is a way to make it configurable, that would be nice (still would have to pick one to be the default, but that's not too big of a deal). |
I am investigating now. |
@maestromac |
Is your feature request related to a problem? Please describe.
We would like to see the tag
partially-approved
only when branch protection's request is not met.Right now, the code also checks if everyone requested has approved it. The combination of CODEOWNER file and our flow, we tend to over-request for reviews, making it impossible for some PR to attain the proper
approved
tag.Describe the solution you'd like
I would like to remove the second portion of this code,
numRequestedReviewsRemaining > 0
. If this is approved and people agree with this, I can submit PR to update this feature.Describe alternatives you've considered
Offer it as a configuration option.
Additional context
I would also like to hear @allout58 's thoughts on this since this is their feature.
The text was updated successfully, but these errors were encountered: