Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can place hitcircles before timing points #31591

Open
ZenoG2 opened this issue Jan 20, 2025 · 3 comments
Open

You can place hitcircles before timing points #31591

ZenoG2 opened this issue Jan 20, 2025 · 3 comments
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game

Comments

@ZenoG2
Copy link

ZenoG2 commented Jan 20, 2025

Type

Game behaviour

Bug description

Opened this at Peppy's request.
You can place circles before timing points
Steps to reproduce:

  1. Make a map
  2. Move the timing point(s) further in the map
  3. Move a hitcircle anywhere before the first timing point
    Congrats! You just broke the game.

Screenshots or videos

https://youtu.be/OeTTwnT81Sk

Version

2025.118.2

Logs

compressed-logs.zip

@peppy
Copy link
Member

peppy commented Jan 20, 2025

First of all, saying that this was "at my request" is a bit of a stretch but let's just let that one slide.

Secondly, placing objects before the first timing point isn't necessarily game breaking. I think there are ranked maps which do this. I believe the issue attempting to be touched on here is that creating a slider and then adjusting the slider velocity before the first timing point will break things.

I guess a fix would be to not allow SV changes before the first timing point. Unless we want to handle it in some other magical way (probably requires stable changes).

@peppy peppy added area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game labels Jan 20, 2025
@OliBomby
Copy link
Contributor

I don't think being able to place hit objects before the first timing point is necessarily the issue. Timing should extend to before the first timing point as well. If there is any weirdness in lazer when hit objects are before the first timing point then we should just fix those symptoms.

I know this causes issues in stable, but instead of changing stable we can fix it by adjusting the legacy exporter to just add an extra timing point before all hit objects.

@peppy
Copy link
Member

peppy commented Jan 22, 2025

That sounds good in theory, but we have to be aware that it's changing mapper intentions. By adjusting the first timing point, we will change when the beat starts being used by various UI elements, as one example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor priority:2 Moderately important. Relied on by some users or impeding the usability of the game
Projects
None yet
Development

No branches or pull requests

3 participants