Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain beatmaps unable to update/download properly #31551

Closed
Skrublord opened this issue Jan 18, 2025 · 4 comments
Closed

Certain beatmaps unable to update/download properly #31551

Skrublord opened this issue Jan 18, 2025 · 4 comments
Assignees
Labels
area:beatmap-change-tracking sync of local-online metadata and status

Comments

@Skrublord
Copy link

Type

Game behaviour

Bug description

When redownloading all of my maps after a soft reset of Windows, a few maps that I was able to download gave me a prompt to update. Most maps would successfully update after clicking the prompt, but a few maps in specific have given me trouble.

https://osu.ppy.sh/beatmapsets/906#osu/14681
https://osu.ppy.sh/beatmapsets/1369#osu/13669
https://osu.ppy.sh/beatmapsets/5170#osu/26057
https://osu.ppy.sh/beatmapsets/9066#osu/36616

https://osu.ppy.sh/beatmapsets/9734#osu/39639 (only the [Hyper] diff)

For the first 4 maps, when clicking update, the map downloads as normal, but the prompt to update never disappears, and the map still shows no global leaderboard. When starting the map, a message appears "Your score will not be submitted. invalid or missing beatmap_hash"

For Genbu - Ganymede [Hyper], the download that starts when clicking update immediately fails (possibly because the map was DMCA'd(?))


Another 2 maps were unable to be downloaded entirely, and I was forced to open the .osz file and manually remove images that were causing problems.

https://osu.ppy.sh/beatmapsets/694#osu/4504 (stage09_070802a-l.jpg needed to be deleted)
https://osu.ppy.sh/beatmapsets/798#osu/6538 (optimusrhyme2.jpg needed to be deleted)

After removing said files from the .osz, the maps were able to be installed

The maps I looked at were all ranked maps from 2007-2012.

Screenshots or videos

Image

Image

Version

2025.101.0-lazer

Logs

compressed-logs.zip

@peppy peppy added the area:beatmap-change-tracking sync of local-online metadata and status label Jan 20, 2025
@bdach bdach self-assigned this Jan 20, 2025
@bdach
Copy link
Collaborator

bdach commented Jan 20, 2025

https://osu.ppy.sh/beatmapsets/906#osu/14681
https://osu.ppy.sh/beatmapsets/1369#osu/13669
https://osu.ppy.sh/beatmapsets/5170#osu/26057
https://osu.ppy.sh/beatmapsets/9066#osu/36616

These ones appear to have md5 sums of the .osu files not matching the online md5. #25078 was supposed to not make this happen again.

https://osu.ppy.sh/beatmapsets/694#osu/4504 (stage09_070802a-l.jpg needed to be deleted)
https://osu.ppy.sh/beatmapsets/798#osu/6538 (optimusrhyme2.jpg needed to be deleted)

These two are just straight up broken zips. The built-in ubuntu archive tool also chokes on these.

Image
Image

These will all require local fixes. @peppy not sure how much of that I can do here, you're probably the best one to handle

@bdach bdach removed their assignment Jan 20, 2025
@peppy peppy self-assigned this Jan 21, 2025
@peppy
Copy link
Member

peppy commented Jan 21, 2025

I'll check on these today.

@peppy
Copy link
Member

peppy commented Jan 21, 2025

#25078 was supposed to not make this happen again.

That run fixed standalone .osu files not matching database hashes. It didn't ensure that these matched the copies in the .osz file. This is a bit of a larger operation which I did run partial fixes for, but not at scale yet. I'll repair these linked beatmaps now. (Done)

These two are just straight up broken zips. The built-in ubuntu archive tool also chokes on these.

I guess we extract as much useful data as we can or find someone with a copy of these to upload a repaired copy.

@peppy
Copy link
Member

peppy commented Jan 22, 2025

I've fixed all issues mentioned in this thread. If other beatmaps are found with similar issues, feel free to raise them in this thread (or open a new thread, or email me at [email protected]).

@peppy peppy closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:beatmap-change-tracking sync of local-online metadata and status
Projects
None yet
Development

No branches or pull requests

3 participants