Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Smart keyboards and trackpads no longer work on SDL iPadOS #23290

Closed
Jed666 opened this issue Apr 23, 2023 · 15 comments
Closed

Apple Smart keyboards and trackpads no longer work on SDL iPadOS #23290

Jed666 opened this issue Apr 23, 2023 · 15 comments
Assignees
Labels
platform/iOS priority:1 Very important. Feels bad without fix. Affects the majority of users. type:input

Comments

@Jed666
Copy link

Jed666 commented Apr 23, 2023

Type

Game behaviour

Bug description

keyboards that connect through the smart connector on the located on the left side in portrait orientation on ipads no longer work except for text input, with the trackpad semiworking but still broken, registering one click as two clicks and the native ipad cursor appearing overlaid ontop of the osu cursor. (also right clicks dont work but i think thats a problem with smart connector keyboards in general, so i also request control clicks be added (control clicks work outside of osu fyi)

System infomation:
iPad 9th gen (iPadOS 16.4.1)
Logitech Combo Touch (with latest firmware (v00.13-00.12)

apologies if this is written badly.

Screenshots or videos

IMG_0624
https://youtu.be/M9_r-fZH4qo

Version

2023.326.0 and later.

Logs

cant show log files cause itunes wont cooperate.

@Jed666
Copy link
Author

Jed666 commented Apr 23, 2023

should have said this earlier but it worked perfectly in older versions. (other then right click)

@Jed666
Copy link
Author

Jed666 commented Apr 23, 2023

last compatible ver: 2023.305.0
IMG_0625
https://youtu.be/0osR-QXTsRg

@frenzibyte
Copy link
Member

Since 2023.326.0, we've transitioned to using SDL for iOS, which means relying on their input handling implementation.

Hardware keyboard not working is currently tracked on their side at libsdl-org/SDL#6465. Check if doing as mentioned in libsdl-org/SDL#6465 (comment) fixes the issue for you.

As for the trackpad issue, I'll need logs to further investigate this.

@frenzibyte frenzibyte added priority:0 Showstopper. Critical to the next release. type:input platform/iOS labels Apr 24, 2023
@frenzibyte frenzibyte self-assigned this Apr 24, 2023
@frenzibyte frenzibyte changed the title osu!lazer no longer has support for apple smart keyboards on ipad after veldrid update. Apple Smart keyboards and trackpads no longer work on SDL Apr 24, 2023
@frenzibyte frenzibyte changed the title Apple Smart keyboards and trackpads no longer work on SDL Apple Smart keyboards and trackpads no longer work on SDL iPadOS Apr 24, 2023
@Jed666
Copy link
Author

Jed666 commented May 18, 2023

finally got logs. these logs are from the most recent release as of writing this.

network.log
performance.log
runtime.log
database.log
input.log

@frenzibyte
Copy link
Member

Hmm, unfortunately, logs don't show anything useful as-is, I'll need someone on the team able to reproduce this and investigate further (cc @peppy).

@frenzibyte frenzibyte removed their assignment Jun 4, 2023
@NiceAesth
Copy link
Contributor

NiceAesth commented Aug 2, 2023

The keyboard portion of this has been fixed upstream in SDL: libsdl-org/SDL@f5ea6ae

After testing with a Logitech Combo Touch, I cannot reproduce the aforementioned double click issues (2023.717-0).

The cursor and right click issues are still present (should possibly be a different issue as they are not related to hardware keyboards necessarily?)

@Jed666
Copy link
Author

Jed666 commented Aug 2, 2023

in regards to the right click,
on attempt on using it in other areas on my my ipad with the keyboard, i havent been able to use the function whatsoever.

but. with a bluetooth mouse connected (also by logitech if that matters), it has been working perfectly even within osu! itself so the right click issues are probably an issue with the combo touch itself.

i dont know if the right click is just broken on my combo touch, or if it affects everyone of them, but taking niceaesth’s comment into mind, id assume it affects all of them.

further testing may be required.

@NiceAesth
Copy link
Contributor

NiceAesth commented Aug 2, 2023

Right click is functional, tested again. You have to click with two fingers to activate it. (Where you click on the trackpad is irrelevant)

Two finger scroll is a bit iffy since it is very very fast

@Jed666
Copy link
Author

Jed666 commented Aug 3, 2023

ahh i see, didnt know it had to be done that way (im used to windows trackpads).

im having the same issue with two finger scroll aswell.

@peppy peppy added priority:1 Very important. Feels bad without fix. Affects the majority of users. and removed priority:0 Showstopper. Critical to the next release. labels Sep 14, 2023
@peppy
Copy link
Member

peppy commented Dec 18, 2023

I guess we might just need an SDL bump to fix this? First we'd want to confirm we haven't already bumped SDL since the reported fix

@smoogipoo
Copy link
Contributor

I think we close this for now and hope this is fixed with SDL3.

@NiceAesth
Copy link
Contributor

Tested on latest release, can confirm it works

@NiceAesth
Copy link
Contributor

This has regressed again with the latest release of iOS. I don't have much to add for the moment other than the fact I have found a way to reproduce this without a smart keyboard by using universal control and attempting to type with your macbook keyboard on iPadOS

@frenzibyte
Copy link
Member

I have been reproducing this issue both with the Universal Control approach mentioned above and with my bluetooth Keychron K4 keyboard, and I can say this should hopefully be resolved in a new SDL build with libsdl-org/SDL#11406 included.

I don't have an Apple Smart keyboard to test and confirm it works as well, but one would hope that the Apple Smart keyboard is more likely to work than a third-party device. Also I'm not really sure how much of the "trackpad" part of this is relevant nowadays (it should be split to a different issue thread anyway).

@frenzibyte
Copy link
Member

Fixed since ppy/osu-framework#6486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/iOS priority:1 Very important. Feels bad without fix. Affects the majority of users. type:input
Projects
None yet
Development

No branches or pull requests

6 participants