-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Spam Filtering Using Akismet. #615
Conversation
Added support for Akismet integration.
Adding Akismet project to Solution to Build from with Visual Studio while building the solution.
Rolled back all changes other than adding Akismet project.
Simple code formatting and clean up for esthetics and readability.
…ering. Included a top level check to not even check for spam if filtering service for spam detection is not set to true.
Upgrade of underlying target framework for the project.
I have submitted the PR but the checks keep failing with this log in the pipeline: 2022-01-28T20:39:26.9131489Z ##[section]Starting: DotNetCoreCLI The Same command however works locally for me: Not sure if I did something wrong or it's an issue with the pipeline in general. The whole flow is working perfectly on my machine and even seems to be passing build and test cases in the pipeline. Not sure why publish is failing. Right now I tried the same set of commands the pipeline is firing on my local machine and it all seems to work. If there is something that needs to be fixed at my end please do let me know and I'll be happy to fix. Not sure why the publish is unable to find the akismet dll on the pipeline box. I am leaving the PR open. It'll be really nice if you can review it once and please do let me know if I am doing something wrong or it's some issue that needs to be fixed on the pipeline. If I need to fix it, I'll do that right away. |
Documentation Available here: #599 (comment) |
@thousandtyone Thx for the PR. Sorry I took so long to respond. I will take a look at this in the next day or so. |
@thousandtyone Again thanks for your patience. I have been told I need to fix an issue with the build (Framework dependency is broken). So my plan at first was to attempt to resolve this issue at the same time, but in all honesty I am feeling less comfortable about making Akismet part of the dasblog project directly. I have spent a lot of time trying to narrow the focus to the essential and necessary and just consume Nuget packages. Here are my thoughts:
I am not sure how you feel about doing this work, I also do not want to assume that I can just take your Akismet project and just make a Nuget package under my Github name (I am really happy to do this but again, how do you feel?). Please let me know which way you would prefer to go. Again, thanks for your contributions! |
@poppastring Really sorry about the rather late response on this one. I am absolutely fine with taking any direction you would want to take. Please feel free to take my work and make a nuget package under your github name. No worries! As long as dasblog gets akismet support we all benefit from it! :) Also if there is any way in which I can further contribute or help please feel free to let me know. |
PR Contains Fix as described in #599. Entire end to end flow has been tested and works. Here are the high level changes that are done:
The end to end flows work. More documentation with screenshot of how this works appended with the issue. Happy to make any other changes that you feel might be required.