[Toggler, List column] Padding/spacing fixes #739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-f0x
changed the title
git-f0x
changed the title
mmstick
approved these changes
Dec 2, 2024
|
Oh, this got merged! Should I close this? |
|
I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the extra padding on the toggler after the rebase, which caused misalignment in apps (not quite sure why spacing adds padding).
Also fixes the header corner gaps in apps without a content container (e.g.
cosmic-term).Edit: The second commit matches the spacing/padding variables used in the list column to designs, and removes the
list::containerwidget, since it's sparingly used (in 6 places across allpop-osrepos), and its padding was often overriden when used.A container with
.class(theme::Container::List)can be used instead.If this isn't desired, it can be added back, with possibly the padding removed.