New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dismiss more than one feature #3031
Comments
Currently, popping two layers in a nav tree will cause intermediate, invalid stores to send `dismiss` actions when they shouldn't. This branch avoids this by checking the store's validity before sending the action along. Fixes #3031.
Currently, popping two layers in a nav tree will cause intermediate, invalid stores to send `dismiss` actions when they shouldn't. This branch avoids this by checking the store's validity before sending the action along. Fixes #3031.
Thanks for the report! We'll be suppressing that warning in the next release, which should come later today. I'll note that SwiftUI doesn't support nested navigation destinations like this very well, so you may want to consider stack navigation in the future, but if it works for you and the OSes you deploy to, at least you should be warning-free soon 😄 |
Thank you too! |
Description
I use tree-based navigation provided TCA. In some cases I need to dismiss to root feature. It works, but I see runtime warning about dismiss action that not handled because feature is nil.
I'm not sure that it's bug, but don't know how to remove this warning
Checklist
main
branch of this package.Expected behavior
You dismiss to root feature and not see runtime warning
Actual behavior
You dismiss to root feature and see runtime warning
Steps to reproduce
LongDismissExample.zip
The Composable Architecture version information
1.10.1
Destination operating system
iOS 17.4
Xcode version information
15.3
Swift Compiler version information
The text was updated successfully, but these errors were encountered: