Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: built-in pnpm modules cache manager #19

Closed
septs opened this issue Jul 30, 2021 · 5 comments · May be fixed by #20
Closed

feature request: built-in pnpm modules cache manager #19

septs opened this issue Jul 30, 2021 · 5 comments · May be fixed by #20
Labels
enhancement New feature or request

Comments

@septs
Copy link

septs commented Jul 30, 2021 •
edited by KSXGitHub

Built-in pnpm modules cache manager

Reduce boilerplate statements

e.g:

- uses: pnpm/[email protected]
  with:
    version: latest
    cache: true
@KSXGitHub KSXGitHub added the enhancement New feature or request label Jul 30, 2021
@KSXGitHub
Copy link
Collaborator

I have no objection, but I'm busy right now, so I will accept pull requests.

@dominikg
Copy link

dominikg commented Aug 5, 2021 •
edited

note, action setup-node has added pnpm caching too https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#caching-packages-dependencies

and documents using this action to install pnpm

@wuzzeb wuzzeb mentioned this issue Sep 8, 2021
Open
@oscard0m
Copy link

oscard0m commented Nov 6, 2021

Should we close this issue considering setup-node is giving support to it?

@dominikg do you think it would have sense to ask for pnpm to be included by default in steup-node as it does with npm and yarn ?

@dominikg
Copy link

dominikg commented Nov 6, 2021

I don't think setup node handles installation of package managers other than npm that comes with the specified node version. iirc yarn is included as part of the hosted runner virtual env, but they declined to include pnpm

actions/runner-images#2279

This action or a run step npm i -g pnpm work reasonably fast and are flexible for users so i'm not sure there is a lot of demand/support for a builtin version

@oscard0m
Copy link

oscard0m commented Nov 7, 2021

I don't think setup node handles installation of package managers other than npm that comes with the specified node version. iirc yarn is included as part of the hosted runner virtual env, but they declined to include pnpm

actions/virtual-environments#2279

Yep, I was thinking of using the same approach as yarn (I didn't know about actions' virtual environment). Thanks for this input here @dominikg.

With this said, should we close this issue @septs @KSXGitHub ?

@septs septs closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Download releases from github wuzzeb/action-setup
4 participants
@dominikg @oscard0m @septs @KSXGitHub