Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Rule misnomer for JUnit* rules #4532

Open
jsotuyod opened this issue May 2, 2023 · 1 comment · May be fixed by #4965
Open

[java] Rule misnomer for JUnit* rules #4532

jsotuyod opened this issue May 2, 2023 · 1 comment · May be fixed by #4965
Labels
in:documentation Affects the documentation
Milestone
7.2.0

Comments

@jsotuyod
Copy link
Member

jsotuyod commented May 2, 2023 •
edited

A bunch of JUnit* rules are incorrectly named given their current actual scope.

  • JUnit4TestShouldUseBeforeAnnotation actually checks for a correct transition from JUnit 3 to either 4 or 5.
  • Same applies to JUnit4TestShouldUseTestAnnotation
  • JUnitAssertionsShouldIncludeMessage applies to both, JUnit and TestNg
  • JUnitTestContainsTooManyAsserts applies to both, JUnit and TestNg
  • With [java] Fix #4503: A false negative about JUnitTestsShouldIncludeAssert and testng #4507, JUnitTestsShouldIncludeAssert applies to both, JUnit and TestNg

Additionally, documentation should be revised to ensure it reflect this clearly.

Originally posted by @jsotuyod in #4507 (comment)
@jsotuyod jsotuyod added the in:documentation Affects the documentation label May 2, 2023
@adangel adangel mentioned this issue Aug 5, 2023
Closed
@jsotuyod
Copy link
Member Author

JUnit4TestShouldUseTestAnnotation is also applicable to JUnit 4+ and TestNG

@jsotuyod jsotuyod linked a pull request Apr 17, 2024 that will close this issue
Draft
4 tasks
@jsotuyod jsotuyod added this to the 7.1.0 milestone Apr 18, 2024
@adangel adangel modified the milestones: 7.1.0, 7.2.0 Apr 25, 2024
@adangel adangel removed the has:pr label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in:documentation Affects the documentation
Projects
None yet
Milestone
7.2.0
Development

Successfully merging a pull request may close this issue.

[java] Rename JUnit rules with overly restrictive names Monits/pmd
2 participants
@jsotuyod @adangel