Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Deprecate PMDConfiguration#setClassloader and #getClassloader #4953

Open
adangel opened this issue Apr 11, 2024 · 0 comments
Open

[core] Deprecate PMDConfiguration#setClassloader and #getClassloader #4953

adangel opened this issue Apr 11, 2024 · 0 comments
Labels
a:suggestion An idea, with little analysis on feasibility, to be considered is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them

Comments

@adangel
Copy link
Member

adangel commented Apr 11, 2024

That's a suggestion for now:

  • Deprecate setClassloader/getClassloader
  • refactor PMDConfiguration to deal with a list of strings (a "classpath")
  • create the classloader only later, fully internally
  • Do not expose this classloader in any way in the public API

That way:

  • we are not tied anymore to using a classloader impl to load class files
  • we can make sure to close all files behind us

Refs:
@adangel adangel added a:suggestion An idea, with little analysis on feasibility, to be considered is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them labels Apr 11, 2024
@adangel adangel mentioned this issue Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:suggestion An idea, with little analysis on feasibility, to be considered is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adangel